Allow overriding of default button style variables #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump + context: I'm shopping for CSS frameworks, and this Skeleton fork seems the least dead + most relevant to what I'm looking for... but several totally sensible PRs like this hanging open for a year isn't a good sign. @thegecko, are you still using Barebones, or have you moved on to something else? |
|
Not used if for a year :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit variables for the the colours of the default buttons.
This enables a user to override the default button colours, specifically the background colour using:
They all default to the same as before, except for the hover border which is now set to #888888 to match skeleton.
This may be cleaner introducing a new hue for the default button, but I didn't want to break backwards compatibility nor have to deal with a 'transparent' hue colour.